-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
TST: Assist Replace ensure_clean utility function with the temp_file pytest fixture #62435 #62461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
_return_result_expected updated to temp file fixture
fix missed temp file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, could you try using temp_file as an argument instead of converting to a string when doing these modifications, unless the test appears to explicitly be testing a string argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in the next set of changes, will be ready for review once tests are successful
Thanks @pandeconscious
Uh oh!
There was an error while loading. Please reload this page.
ensure_cleanutility function with thetemp_filepytest fixture #62435 as part of a larger effort(削除) Tests added and passed if fixing a bug or adding a new feature(削除ここまで)(削除) Added type annotations to new arguments/methods/functions.(削除ここまで)(削除) Added an entry in the latestdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.(削除ここまで)